Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Translation for to_date and to_timestamp as DBFunctions extensions #2936

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Add Translation for to_date and to_timestamp as DBFunctions extensions #2936

merged 13 commits into from
Mar 20, 2024

Conversation

WhatzGames
Copy link
Contributor

@WhatzGames WhatzGames commented Nov 12, 2023 •
edited by roji
Loading

Discussed in #2505.
After taking an initial look at the different formatting values for dotnet and postgres I was unable to find a suitable map for every DateOnly/DateTime formatting option.
It might be still be possible, but to this extent I just created the DBFunctions extensions.

Closes #2505

@WhatzGames WhatzGames changed the title Add Translation for to_date as a DBFunction extension Add Translation for to_date and to_timestamp as DBFunctions extensions Jan 5, 2024
@WhatzGames WhatzGames requested a review from roji March 19, 2024 21:36
roji
roji approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Pushed a few doc corrections and will merge this for 9.0.

@roji roji merged commit 533b9d3 into npgsql:main Mar 20, 2024
14 of 15 checks passed
@roji
Copy link
Member

roji commented Mar 20, 2024

@WhatzGames thanks for your contribution!

@WhatzGames
Copy link
Contributor Author

@roji I'm just glad it worked out and thank you for letting me have this experience.

@WhatzGames WhatzGames mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use to_date/to_timestamp for translating string to date-format
2 participants
@WhatzGames @roji